implement backend for fetching type conversions#2989
Merged
Conversation
jgao54
force-pushed
the
type-conversion-api
branch
3 times, most recently
from
fd4d36a to
24a8532
Compare
jgao54
force-pushed
the
type-conversion-api
branch
from
24a8532 to
618bdb2
Compare
serprex
reviewed
May 29, 2025
Amogh-Bharadwaj
approved these changes
May 30, 2025
Amogh-Bharadwaj
left a comment
Amogh-Bharadwaj
left a comment
Contributor
There was a problem hiding this comment.
If you could add some comments for the functions in flow/connectors/clickhouse/type_conversion.go that would be great :)
jgao54
force-pushed
the
type-conversion-api
branch
from
a2f40a6 to
b484551
Compare
jgao54
added a commit
that referenced
this pull request
May 30, 2025
Create frontend for [custom column type conversion.](#2989). It creates a dropdown of possible conversions determined by the backend. Right now only numeric -> string is supported. If there are no available conversion, the option for `use custom column destination type` will be hidden. Test: locally created a table that contains column with numeric type, create ClickPipe via UI, and see CH table get created with String type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the backend to support type conversion frontend